Skip to content

[Pick] Don't rely on parameter order when creating VersionRange #5227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Trenly wants to merge 1 commit into from
Closed

[Pick] Don't rely on parameter order when creating VersionRange #5227

Trenly wants to merge 1 commit into from

Conversation

@Trenly
Copy link
Contributor

@Trenly Trenly commented Feb 19, 2025 •
edited by microsoft-github-policy-service bot
Loading

@Trenly
Don't rely on parameter order when creating VersionRange (microsoft#5213
0ed39d0 
)

Instead of relying on the parameters to be in the correct order for
minimum and maximum when creating a VersionRange, the code can instead
just put them in the right order.
@Trenly Trenly requested a review from a team as a code owner February 19, 2025 22:20
@JohnMcPMS
Copy link
Member

JohnMcPMS commented Feb 19, 2025

#5226

@JohnMcPMS JohnMcPMS closed this Feb 19, 2025
@Trenly Trenly deleted the RangePick branch February 19, 2025 22:41
@Trenly
Copy link
Contributor Author

Trenly commented Feb 19, 2025

Ah, didn't see it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Trenly @JohnMcPMS